Question on Making a pull request for bug fix

asked 2019-05-05 08:56:09 -0500

unrandom gravatar image

Hi , I have a question before making a pull request on the github repository(opencv). I have forked the repository and cloned it to my computer. I have already read the instructions on making a pull request link, However i am afraid that i am not fully understanding it.

last time i made a pull request about typo, i pushed it to the master branch directly, thus, i had to follow the instructions to rebase my commits.

From now on, i would like to push it to the upstream/3.4 branch directly so i don`t have to rebase my commits again. If i want to do in such a way, is it then : git add filename git commit -m "commit msg" git push origin upstream/3.4

Thanks for watching

edit retag flag offensive close merge delete

Comments

read this post

git clone https://https://github.com/opencv/opencv
cd opencv
git checkout 3.4
git pull upstream 3.4
git push
git branch IssueXYZK
git checkout IssueXYZK
//change something
git commit -a
git push origin IssueXYZK
// git push origin for first commit
LBerger gravatar imageLBerger ( 2019-05-05 09:45:42 -0500 )edit
2

the git push in the middle -- redundant ?

also: git push origin IssueXYZK (since you're not allowed to push to upstream)

berak gravatar imageberak ( 2019-05-06 03:43:09 -0500 )edit
2

git pull upstream get data on local computer. I make git push to get my github repo even with master (or 3.4)

LBerger gravatar imageLBerger ( 2019-05-06 03:48:51 -0500 )edit