Ask Your Question

making effective pull requests

asked 2013-08-05 19:23:21 -0600

mat_pier gravatar image

updated 2020-10-25 09:17:19 -0600

I've been using OpenCV over the past 3+ years. I've been an enthusiastic user, now trying to be a contributor to the project.

I'm also an newbie on Git. I know how to clone, fork, commit, push code to Github from my PC, edit code on Github. I panic when I have to do complex stuff (I just google in that case).

I have the following questions after doing pull request to the OpenCV project.

  1. What do I do if pull requests shows that my code has certain warnings. Will that be fixed by the person by who is supposed to handle my pull request?
  2. What do I do if there are errors. How to make a new request after fixing errors?

I both cases, do I delete my old fork, make a new fork of project, make changes again, make sure that there are no errors and request a new pull?

edit retag flag offensive close merge delete

2 answers

Sort by ยป oldest newest most voted

answered 2013-08-06 01:53:00 -0600

berak gravatar image

updated 2015-09-01 11:45:39 -0600

  • "Will that be fixed by the person by who is supposed to handle my pull request?"

    no, your job. but you'll probably get some suggestions

  • "do I delete my old fork ?"

    oh no, doing so will destroy all the history with it.just fix the problem, and update your fork(probably with -f option). the buildbot tests will be run automatically.

  • you want a separate branch for every problem you're trying to fix, look here

edit flag offensive delete link more

answered 2013-08-05 21:38:09 -0600

According to the chart on that page, you will be ping by the PoD. So fix your errors and wait before resubmit that the PoD contacts you.

edit flag offensive delete link more


Let me add to this that you should sometimes have a bit of patience before a PR gets redacted and a PoD or follow-up is assigned. Many of the core devs have not enough time for the moment or are busy with other stuff, so a delay of a week is not abnormal.

StevenPuttemans gravatar imageStevenPuttemans ( 2015-09-02 07:41:04 -0600 )edit

@StevenPuttemans I understand that during gsoc delay longer. Is it normal for this PR? I need a review about PR6664.

LBerger gravatar imageLBerger ( 2016-07-01 06:53:42 -0600 )edit

Hello @LBerger, I am afraid we will have to be patient. I have PRs open from similar commit moments that are still waiting for final approval. I am guessing with Intel buying up Itseez, that it will only take a bit longer now :D

StevenPuttemans gravatar imageStevenPuttemans ( 2016-07-01 06:59:29 -0600 )edit

Question Tools


Asked: 2013-08-05 19:23:21 -0600

Seen: 602 times

Last updated: Sep 01 '15