Ask Your Question

Revision history [back]

click to hide/show revision 1
initial version

making effective pull requests

I've been using OpenCV over the past 3+ years. I've been an enthusiastic user, now trying to be a contributor to the project.

I'm also an newbie on Git. I know how to clone, fork, commit, push code to Github from my PC, edit code on Github. I panic when I have to do complex stuff (I just google in that case).

I have the following questions after doing pull request to the OpenCV project.

  1. What do I do if pull requests shows that my code has certain warnings. Will that be fixed by the person by who is supposed to handle my pull request?
  2. What do I do if there are errors. How to make a new request after fixing errors?

I both cases, do I delete my old fork, make a new fork of project, make changes again, make sure that there are no errors and request a new pull?

making effective pull requests

I've been using OpenCV over the past 3+ years. I've been an enthusiastic user, now trying to be a contributor to the project.

I'm also an newbie on Git. I know how to clone, fork, commit, push code to Github from my PC, edit code on Github. I panic when I have to do complex stuff (I just google in that case).

I have the following questions after doing pull request to the OpenCV project.

  1. What do I do if pull requests shows that my code has certain warnings. Will that be fixed by the person by who is supposed to handle my pull request?
  2. What do I do if there are errors. How to make a new request after fixing errors?

I both cases, do I delete my old fork, make a new fork of project, make changes again, make sure that there are no errors and request a new pull?