Ask Your Question

Pull Request about opencv and opencv_contrib

asked 2016-11-21 02:09:02 -0500

LBerger gravatar image


I want to make a pull request about how opencv_contrib module detect glog gflags eigen and ceres. I think that some file should move in folder opencv/cmake like dnn/OpenCVFindLibProtobuf.cmake and sfm/FindGflags.cmake to avoid multi cmake variable for same detection.

To make a pull request I have to create a branch. But when I create a branch in opencv git check opencv folder and when I create a branch in opencv_contrib git check opencv_contrib folder. Is it possible to create a branch working for opencv and opencv_contrib?

Thanks for your answer

PS may be stackoverflow is a good place for this question too

edit retag flag offensive close merge delete


I have found a way :

create a branch CMakeSFMCAFFE in opencv and clone opencv_contrib in a new folder opencv_contrib_test. Then I give this path in CMakeGUI to opencv_extra_module_path.

It is not good like a branch but I can test without killing my good configuration of opencv and opencv_contrib

LBerger gravatar imageLBerger ( 2016-11-21 03:15:24 -0500 )edit

1 answer

Sort by ยป oldest newest most voted

answered 2016-11-21 02:30:42 -0500

No it is not. Simply said, both opencv and opencv_contrib are seperate repositories. A PR with fixes in both repositories needs to be split into two seperate PRs, since PR is specific for a single repository and a single branch on that repository.

edit flag offensive delete link more


I have started my PR. I discover that opencv buildbot need opencv_contrib for Win7 x64 VS2013, Win10 x64 VS2015 and Win 32. Example in file I have got an link error relative to HDF module (opencv_contrib). If I search opencv_contrib in this file I can find it. That's weird. I'm waiting an answer from alalek

LBerger gravatar imageLBerger ( 2016-11-22 02:55:57 -0500 )edit

Please link PR so that we can have a look if you want!

StevenPuttemans gravatar imageStevenPuttemans ( 2016-11-22 03:00:48 -0500 )edit

Question Tools

1 follower


Asked: 2016-11-21 02:09:02 -0500

Seen: 126 times

Last updated: Nov 21 '16