Ask Your Question

Revision history [back]

click to hide/show revision 1
initial version

Ok, I found the paper that the algorithm comes from, and there are some differences. Hewing closer to the original algorithm fixes the problem, at least for this example.

Namely, there is a comment in fitEllipse

// A - C signs inverted as proposed by APP

then three lines with negatives. If those negatives are removed, you get the correct answer.

This also fixes #4515 and #6544. That makes me happy, so I'll run the tests and commit the changes.

Ok, I found the paper that the algorithm comes from, and there are some differences. Hewing closer to the original algorithm fixes the problem, at least for this example.

Namely, there is a comment in fitEllipse

// A - C signs inverted as proposed by APP

then three lines with negatives. If those negatives are removed, you get the correct answer.

This also fixes #4515 and #6544. That makes me happy, so I'll run the tests and commit the changes.

EDIT: Hmm, it is failing some tests though. More work to do.