Removal of BRIEF from main repository

asked 2014-09-01 02:37:04 -0500

PhilLab gravatar image

updated 2014-11-25 03:32:30 -0500

Does anyone know why the BRIEF feature descriptor has been moved to the contrib repository? Is it nonfree? BRIEF is well-matured and used in tons of OpenCV examples both in the official documentation and the internet. Plus, the combination FAST+BRIEF is like a "Hello World" for feature detection IMHO :-).

EDIT: Additionally, the integration of the contrib repository seems still a little buggy - e.g. using xfeatures2d together with the world module fails in the CMake generation.

edit retag flag offensive close merge delete

Comments

1

Because BRIEF is broken, by means that the internal calculation doesn't match the original implementation. That is what I got from following some bug reports. As to integrating contrib and bugs, I know, cant seem to get it bugfree here also.

StevenPuttemans gravatar imageStevenPuttemans ( 2014-11-26 08:46:14 -0500 )edit

I exactly have this issue with the contrib repo. I wanted to test the FREAK descriptor but was unable to build on CMAKE. As about the world module, I was about to ask what was its use (I don't include it manually but it might be used by other modules) and looking at the source tells me that there is the initAll() function but I don't see anything else. Actually, if there is a list somewhere detailing the content of each module I could read to better understand. Thanks!

Doombot gravatar imageDoombot ( 2014-11-26 09:13:13 -0500 )edit

BRIEF is broken ? how so ?

berak gravatar imageberak ( 2014-11-26 09:19:04 -0500 )edit

Ah, thanks for the update :-)

PhilLab gravatar imagePhilLab ( 2014-11-27 03:26:23 -0500 )edit

@berak I am not sure but it seems that all broken/patented functionality got removed. That being said stuff like create_samples was not broken but got removed nevertheless. I guess someone should focus on the reasons for that :)

StevenPuttemans gravatar imageStevenPuttemans ( 2014-11-27 05:56:11 -0500 )edit
2

@Doombot, I am building up content docs on the contrib modules as we speak. It will take me some spare time tough to finish it. When browsing github repo you can already see all the README files appearing.

StevenPuttemans gravatar imageStevenPuttemans ( 2014-11-27 05:57:37 -0500 )edit