Ask Your Question

TermCriteria in LogisticRegression

asked 2020-08-04 03:42:29 -0500

ffolch gravatar image

TermCriteria is not stored in the model file But, when using miniBatch, its member maxCount is used in a loop

Mat LogisticRegressionImpl::mini_batch_gradient_descent(const Mat& _data, const Mat& _labels, const Mat& _init_theta)

... for(int i = 0;i<this->params.term_crit.maxCount;i++)

(instead, the loop in batch_gradient_descent uses the variable >params.num_iters)

isn't this an error?

edit retag flag offensive close merge delete

1 answer

Sort by ยป oldest newest most voted

answered 2020-08-04 06:47:14 -0500

berak gravatar image

updated 2020-08-04 07:06:24 -0500

that's a bug.

it also checks for num_iters before, not for the termcriteria, epsilon value is never used, and also it neither writes or reads the termcrit in a file.

time for an issue, i guess

(and in the end, the TermCriteria should probably be removed, no ?)

edit flag offensive delete link more

Question Tools

1 follower


Asked: 2020-08-04 03:42:29 -0500

Seen: 57 times

Last updated: Aug 04 '20