Calculate length between 2 points in c++

asked 2016-10-05 03:21:02 -0500

vivekkh gravatar image

updated 2016-10-13 18:55:49 -0500

I need to calculate length of lines(number of pixels along the path) from a point until a terminal point. terminal point is a point which either ends or which has more than one line starting from that point. For example, in below image I need to calculate length between A->B, A->C, A->D.

I have attempted but then it goes into forever loop and I am not understanding why. I am new to work with images. so to do that I want to implement a logic in which I select neighbouring 8 pixels of a point and if its 1 then it should do a depth first till terminal and store that point in a hashmap. Please give me any suggestions. I am stuck on this. I can also share the original image if thats required. below image is only to explain problem

image description

#include "stdafx.h"
#include <stdio.h>
#include <iostream>
#include <fstream>
#include <unordered_set>
#include <unordered_map>

#include "opencv2/core/core.hpp"
#include "opencv2/features2d/features2d.hpp"
#include <opencv2\highgui.hpp>
#include <opencv2\nonfree\features2d.hpp>
#include "opencv2/calib3d/calib3d.hpp"
#include "opencv2/imgproc/imgproc.hpp"
#include <opencv2\legacy\legacy.hpp>

using namespace cv;
using namespace std;

#define ERR(msg) printf("%s : %d", (msg), __LINE__)

struct point_hash {
    inline std::size_t operator()(const cv::Point & v) const {
        return v.x * 61 + v.y;
    }
};

unordered_multimap<Point,int, point_hash> lengths;

bool is_terminal(Mat &image,Point grid, unordered_set<Point, point_hash>& visited) {
    cout << "This point is 1:Terminal:"  << endl;
    int count = 0;
    for (int i = grid.x-1; i < grid.x+2; i++) {
        for (int j = grid.y - 1; j < grid.y + 2; j++) {
            if ((int) image.at<char>(j,i) > 0 && visited.find(Point(i,j)) == visited.end()) {
                count++;
            }
        }
    }
    if (count > 1) {
        return true;
    }else
        return false;
}

int check_length(Mat &image, Point kp,Point start, int length, unordered_set<Point, point_hash> visited) {
    cout << "Get Neighbouring points" << kp.x << " " << kp.y << endl;
    visited.insert({ kp });
    if (start!=kp && is_terminal(image, kp, visited)) {
        lengths.insert({ start,length });
        return 0;
    }
    else {
        if ((int)image.at<uchar>(kp.y - 1, kp.x - 1) > 0 && visited.find(Point(kp.x - 1, kp.y - 1)) == visited.end()) {
            check_length(image, Point(kp.x - 1, kp.y - 1), start, length + 1, visited);
        }
        if ((int)image.at<uchar>(kp.y, kp.x - 1) > 0 && visited.find(Point(kp.x - 1, kp.y)) == visited.end()) {
            check_length(image, Point(kp.x - 1, kp.y), start, length + 1, visited);
        }
        if ((int)image.at<uchar>(kp.y + 1, kp.x - 1) > 0 && visited.find(Point(kp.x - 1, kp.y + 1)) == visited.end()) {
            check_length(image, Point(kp.x - 1, kp.y + 1), start, length + 1, visited);
        }
        if ((int)image.at<uchar>(kp.y - 1, kp.x) > 0 && visited.find(Point(kp.x, kp.y - 1)) == visited.end()) {
            check_length(image, Point(kp.x, kp.y - 1), start, length + 1, visited);
        }
        if ((int)image.at<uchar>(kp.y + 1, kp.x) > 0 && visited.find(Point(kp.x, kp.y + 1)) == visited.end()) {
            check_length(image, Point(kp.x, kp ...
(more)
edit retag flag offensive close merge delete

Comments

you're reading img2, but use (undeclared) img1. - this can't be your real code.

berak gravatar imageberak ( 2016-10-05 03:27:24 -0500 )edit

this is real code I was trying something so I took initial image in img2 and then was after checking if its binary I was passing it to check length function. I removed binary check step so this typo.

vivekkh gravatar imagevivekkh ( 2016-10-05 03:35:16 -0500 )edit
1

still, atm you're reading a colour image.

please make it so, that folks can just c/p your code and try it !

berak gravatar imageberak ( 2016-10-05 03:45:59 -0500 )edit

I am not able to get it in binary form using that code so I removed it. I am getting this image from octave which is in terms of 1 and 0 but dint find any way to directly store an image in binary format. I know its histogram from 0-255 and when trying to threshold based on value(50). I end up losing important points. any suggestions on how I can do it?

vivekkh gravatar imagevivekkh ( 2016-10-05 03:53:11 -0500 )edit

imread(filename, 0); will read in a 8bit uchar img

berak gravatar imageberak ( 2016-10-05 03:54:34 -0500 )edit

this does not give me binary image because looking at max and min values it still gives min as 0 and max as 255.

vivekkh gravatar imagevivekkh ( 2016-10-05 04:09:11 -0500 )edit

this is correct, that's how binary images look like in opencv.

you have to be very careful, porting matlab/octave ideas to opencv, there are a lot of subtle differences (indexing, interleaving, row/col majorness, etc).

berak gravatar imageberak ( 2016-10-05 04:15:43 -0500 )edit
1

any suggestions about the logic or if there is some error in that implementation. because I have considered as if(pixel val > 0) condition.

vivekkh gravatar imagevivekkh ( 2016-10-05 04:28:02 -0500 )edit

maybe you need 2 passes:

  1. (given you have a proper 1 pixel wide "skeleton") try to find your "interest points". if it's A, and B, those are bifurcations / T-junctions, points with exactly 3 "on" neighbours, D is an end-point with exactly 1 neighbour. (maybe also see here)
  2. then, do a depth-first search from one to the other.

sidenote: opencv uses white pixels for "on", and black ones for "off". maybe you have to invert your binary image.

berak gravatar imageberak ( 2016-10-13 23:20:25 -0500 )edit