buildbot does not find xfeatures2d.hpp

asked 2015-02-15 08:38:39 -0500

berak gravatar image

updated 2015-02-15 08:44:46 -0500

i'm trying to make a pr to the contrib repo here, but none of the buildbots can find either

#include <opencv2/xfeatures2d.hpp>

or

#include "opencv2/xfeatures2d.hpp"

/builds/precommit-contrib_linux64/opencv_contrib/modules/reg/samples/map_test.cpp:51:35: fatal error: opencv2/xfeatures2d.hpp: No such file or directory
 #include "opencv2/xfeatures2d.hpp"

what might this be ? i'm puzzled.

edit retag flag offensive close merge delete

Comments

Hmm I am guessing some broke it :D that should not be happening :P

StevenPuttemans gravatar imageStevenPuttemans ( 2015-02-15 08:45:07 -0500 )edit

Are you sure that it isn't because of the

+#define COMPARE_FEATURES
#ifdef COMPARE_FEATURES
StevenPuttemans gravatar imageStevenPuttemans ( 2015-02-15 08:47:50 -0500 )edit

well, ofc. it is, because i enabled the feature comparison now. (that's why the compiler even looks at that code now). i just don't understand, what's wrong with the include.

or, do you think, i'm missing a newline or something else ? something not kosher with the define ?

berak gravatar imageberak ( 2015-02-15 08:55:32 -0500 )edit

I rather think that there must be something with that feature comparison thing which renders your include useless. Can your try moving that compare features define right before that namespace declaration and see if the include error still exist?

StevenPuttemans gravatar imageStevenPuttemans ( 2015-02-15 09:02:15 -0500 )edit
1

ohh. sure. good idea.

(thanks for lookijng into it, btw)

berak gravatar imageberak ( 2015-02-15 09:03:31 -0500 )edit
1

Looks fine to me. And it runs properly for me. Your include syntax that is.

Potato gravatar imagePotato ( 2015-02-15 09:03:55 -0500 )edit
1

My #define COMPARE_FEATURES is right after #define _USE_MATH_DEFINES. I don't think that should matter though.

Potato gravatar imagePotato ( 2015-02-15 09:22:46 -0500 )edit
1

thanks, @Potato .

made a test with a different sample - compiled fine, so it must be something special with either the reg module or map_test.cpp

berak gravatar imageberak ( 2015-02-15 09:36:06 -0500 )edit

I dont know if your second test is good @berak. the normal headers are quite different from the contrib ones. Could you adapt that PR to include the xfeatures2d header and see if that still works? I do not think the core header is a good representative :D

StevenPuttemans gravatar imageStevenPuttemans ( 2015-02-15 09:48:48 -0500 )edit
3

@StevenPuttemans, the 2nd test was surf_matcher.cpp from the xfeatures2d samples, just to see if that would find the header (it did)

looking at the CmakeLists.txt in reg/samples again, i just discovered, that it already defines COMPARE_FEATURES, so i guess i 'll just revert the pr to the original version (without a #define in the code), and call it a false alarm (though i'll never know, what exactly went wrong...)

berak gravatar imageberak ( 2015-02-15 10:02:55 -0500 )edit