Line features descriptors cannot be referenced outside opencv [closed]
I was playing with the line features tutorial. I set up a tutorial project according to here link
But when I compile it I got the following error
error C1189: #error : this is a private header which should not be used from outside of the OpenCV library
It seems no functions in the module line_descriptor are allowed to be referenced outside the opencv library itself because of the header "private.hpp".
Another thing I notice is that the LSDDetector actually has two independent versions of implementation. They locate at the module imgproc and line_descriptor separately. Why is that? Is it just because the module line_descriptor is unstable? I'd like to help to speedup the development of the line_descriptor? How can I submit my implementation?
Thank you in advance!
oh, you're right. bug in the tutorial/sample code.
make an issue and prepare a pull-request ?
Hey Berak, thanks for the quick response. I've created a new issue and have fixed the bug. (It's real simple just comment off the #inculde "private.hpp" from both the line_descriptor library as well as the tutorial. But how can I submit the fix then?
Is it just update the issue and choose the source code files I corrected and submit?
Here is the link to the issue http://code.opencv.org/issues/3996
if you can do a proper github pull request ( for the opencv_contrib repo ) - they'll love it !
(imho, the samples there(modules/line_descriptor/samples, and the code in doc/tutorial.rst might need the same treatment, too)
anyway, great start !! ;)
hmm. imho something went wrong.
why is it marked 'Done' ? ( it's no more 'open', so people there won't even see it ! )
Hey Berak, thanks a lot for your instruction. Sorry, I was pretty busy last week and didnt get it done util now. I create a pull request by following this page http://code.opencv.org/projects/opencv/wiki/Windows_7_and_TortoiseGit_contribution_guide. Here is what I have https://github.com/Itseez/opencv_contrib/pull/126
I've also switched the Issue from done back to open.